refactor

utils/orb_block_data.cpp

@@ -2,13 +2,13 @@
 #include "json_functions_bno.h"
 
 orb_block_data::orb_block_data(
-    std::string orbitid,
+    const std::string& orbitid,
     const TimeJD& date,
     const TimeJD& beg,
     const TimeJD& end
 )
     :
-    m_orbitid(std::move(orbitid)),
+    m_orbitid(orbitid),
     m_date(date),
     m_beg(beg),
     m_end(end),
@@ -17,16 +17,16 @@ orb_block_data::orb_block_data(
 }
 
 orb_block_data::orb_block_data(
-    std::string orbitid,
+    const std::string& orbitid,
     const TimeJD& date,
     const TimeJD& beg,
     const TimeJD& end,
     const double mind,
-    std::string next_orbitid
+    const std::string& next_orbitid
 )
     :
-    m_orbitid(std::move(orbitid)),
-    m_next_orbitid(std::move(next_orbitid)),
+    m_orbitid(orbitid),
+    m_next_orbitid(next_orbitid),
     m_date(date),
     m_beg(beg),
     m_end(end),
@@ -35,16 +35,16 @@ orb_block_data::orb_block_data(
 }
 
 orb_block_data::orb_block_data(
-    std::string orbitid, 
+    const std::string& orbitid,
     const TimeJD& date, 
     const TimeJD& beg, 
     const TimeJD& end,
     const double mind, 
-    std::string next_orbitid, 
+    const std::string& next_orbitid, 
     const std::vector<IRes>& vecs)
     :
-    m_orbitid(std::move(orbitid)),
-    m_next_orbitid(std::move(next_orbitid)),
+    m_orbitid(orbitid),
+    m_next_orbitid(next_orbitid),
     m_date(date),
     m_beg(beg),
     m_end(end),

utils/orb_block_data.h

@@ -4,29 +4,29 @@
 #include "json_functions.h"
 #include "ires.h"
 
-class orb_block_data {
+class orb_block_data
+{
 public:
     orb_block_data() = default;
     orb_block_data(
-        std::string orbitid,
+        const std::string& orbitid,
         const TimeJD& date,
         const TimeJD& beg,
         const TimeJD& end);
     orb_block_data(
-        std::string orbitid,
+        const std::string& orbitid,
         const TimeJD& date,
         const TimeJD& beg,
         const TimeJD& end,
         double mind,
-        std::string next_orbitid);
-
+        const std::string& next_orbitid);
     orb_block_data(
-        std::string orbitid,
+        const std::string& orbitid,
         const TimeJD& date,
         const TimeJD& beg,
         const TimeJD& end,
         double mind,
-        std::string next_orbitid,
+        const std::string& next_orbitid,
         const std::vector<IRes>& vecs
     );
     void load(const jsonval& parent);